feat(filter): add rejection on invalid size set (#991)

* feat(filter): add rejection on invalid size set

* return false
This commit is contained in:
soup 2023-06-19 18:44:34 +02:00 committed by GitHub
parent c587c07b36
commit 1fbf3c828e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -551,7 +551,8 @@ func (f Filter) checkSizeFilter(r *Release, minSize string, maxSize string) bool
// string to bytes // string to bytes
minSizeBytes, err := humanize.ParseBytes(minSize) minSizeBytes, err := humanize.ParseBytes(minSize)
if err != nil { if err != nil {
// log could not parse into bytes r.addRejectionF("size: invalid minSize set: %s err: %q", minSize, err)
return false
} }
if r.Size <= minSizeBytes { if r.Size <= minSizeBytes {
@ -565,7 +566,8 @@ func (f Filter) checkSizeFilter(r *Release, minSize string, maxSize string) bool
// string to bytes // string to bytes
maxSizeBytes, err := humanize.ParseBytes(maxSize) maxSizeBytes, err := humanize.ParseBytes(maxSize)
if err != nil { if err != nil {
// log could not parse into bytes r.addRejectionF("size: invalid maxSize set: %s err: %q", maxSize, err)
return false
} }
if r.Size >= maxSizeBytes { if r.Size >= maxSizeBytes {