From 1fbf3c828ec4f534ebe697c46a122966a5600b30 Mon Sep 17 00:00:00 2001
From: soup <soup@r4tio.dev>
Date: Mon, 19 Jun 2023 18:44:34 +0200
Subject: [PATCH] feat(filter): add rejection on invalid size set (#991)

* feat(filter): add rejection on invalid size set

* return false
---
 internal/domain/filter.go | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/internal/domain/filter.go b/internal/domain/filter.go
index 51192e5..3e02a78 100644
--- a/internal/domain/filter.go
+++ b/internal/domain/filter.go
@@ -551,7 +551,8 @@ func (f Filter) checkSizeFilter(r *Release, minSize string, maxSize string) bool
 		// string to bytes
 		minSizeBytes, err := humanize.ParseBytes(minSize)
 		if err != nil {
-			// log could not parse into bytes
+			r.addRejectionF("size: invalid minSize set: %s err: %q", minSize, err)
+			return false
 		}
 
 		if r.Size <= minSizeBytes {
@@ -565,7 +566,8 @@ func (f Filter) checkSizeFilter(r *Release, minSize string, maxSize string) bool
 		// string to bytes
 		maxSizeBytes, err := humanize.ParseBytes(maxSize)
 		if err != nil {
-			// log could not parse into bytes
+			r.addRejectionF("size: invalid maxSize set: %s err: %q", maxSize, err)
+			return false
 		}
 
 		if r.Size >= maxSizeBytes {