mirror of
https://github.com/idanoo/autobrr
synced 2025-07-23 16:59:12 +00:00

* feat(backend): added change password api endpoint. * feat(web): added profile UI to change password. I think we can change the username too, but I don't know if we should for now disabled the username field. * refactor: don't leak username or password. * refactor: protect the route. * generic * feat: add ChangeUsername * fix(tests): speculative fix for TestUserRepo_Update * Revert "feat: add ChangeUsername" This reverts commit d4c1645002883a278aa45dec3c8c19fa1cc75d9b. * refactor into 1 endpoint that handles both * feat: added option to change username as well. :pain: * refactor: frontend * refactor: function names in backend I think this makes it more clear what their function is * fix: change to 2 cols with separator * refactor: update user * fix: test db create user --------- Co-authored-by: Kyle Sanderson <kyle.leet@gmail.com> Co-authored-by: soup <soup@r4tio.dev> Co-authored-by: martylukyy <35452459+martylukyy@users.noreply.github.com> Co-authored-by: ze0s <ze0s@riseup.net>
158 lines
4.4 KiB
Go
158 lines
4.4 KiB
Go
// Copyright (c) 2021 - 2023, Ludvig Lundgren and the autobrr contributors.
|
|
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
package auth
|
|
|
|
import (
|
|
"context"
|
|
|
|
"github.com/autobrr/autobrr/internal/domain"
|
|
"github.com/autobrr/autobrr/internal/logger"
|
|
"github.com/autobrr/autobrr/internal/user"
|
|
"github.com/autobrr/autobrr/pkg/argon2id"
|
|
|
|
"github.com/pkg/errors"
|
|
"github.com/rs/zerolog"
|
|
)
|
|
|
|
type Service interface {
|
|
GetUserCount(ctx context.Context) (int, error)
|
|
Login(ctx context.Context, username, password string) (*domain.User, error)
|
|
CreateUser(ctx context.Context, req domain.CreateUserRequest) error
|
|
UpdateUser(ctx context.Context, req domain.UpdateUserRequest) error
|
|
CreateHash(password string) (hash string, err error)
|
|
ComparePasswordAndHash(password string, hash string) (match bool, err error)
|
|
}
|
|
|
|
type service struct {
|
|
log zerolog.Logger
|
|
userSvc user.Service
|
|
}
|
|
|
|
func NewService(log logger.Logger, userSvc user.Service) Service {
|
|
return &service{
|
|
log: log.With().Str("module", "auth").Logger(),
|
|
userSvc: userSvc,
|
|
}
|
|
}
|
|
|
|
func (s *service) GetUserCount(ctx context.Context) (int, error) {
|
|
return s.userSvc.GetUserCount(ctx)
|
|
}
|
|
|
|
func (s *service) Login(ctx context.Context, username, password string) (*domain.User, error) {
|
|
if username == "" || password == "" {
|
|
return nil, errors.New("empty credentials supplied")
|
|
}
|
|
|
|
// find user
|
|
u, err := s.userSvc.FindByUsername(ctx, username)
|
|
if err != nil {
|
|
s.log.Error().Err(err).Msgf("could not find user by username: %v", username)
|
|
return nil, errors.Wrapf(err, "invalid login: %s", username)
|
|
}
|
|
|
|
if u == nil {
|
|
return nil, errors.Errorf("invalid login: %s", username)
|
|
}
|
|
|
|
// compare password from request and the saved password
|
|
match, err := s.ComparePasswordAndHash(password, u.Password)
|
|
if err != nil {
|
|
return nil, errors.New("error checking credentials")
|
|
}
|
|
|
|
if !match {
|
|
s.log.Error().Msg("bad credentials")
|
|
return nil, errors.Errorf("invalid login: %s", username)
|
|
}
|
|
|
|
return u, nil
|
|
}
|
|
|
|
func (s *service) CreateUser(ctx context.Context, req domain.CreateUserRequest) error {
|
|
if req.Username == "" {
|
|
return errors.New("validation error: empty username supplied")
|
|
} else if req.Password == "" {
|
|
return errors.New("validation error: empty password supplied")
|
|
}
|
|
|
|
userCount, err := s.userSvc.GetUserCount(ctx)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if userCount > 0 {
|
|
return errors.New("only 1 user account is supported at the moment")
|
|
}
|
|
|
|
hashed, err := s.CreateHash(req.Password)
|
|
if err != nil {
|
|
return errors.New("failed to hash password")
|
|
}
|
|
|
|
req.Password = hashed
|
|
|
|
if err := s.userSvc.CreateUser(ctx, req); err != nil {
|
|
s.log.Error().Err(err).Msgf("could not create user: %s", req.Username)
|
|
return errors.New("failed to create new user")
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (s *service) UpdateUser(ctx context.Context, req domain.UpdateUserRequest) error {
|
|
if req.PasswordCurrent == "" {
|
|
return errors.New("validation error: empty current password supplied")
|
|
}
|
|
|
|
if req.PasswordNew != "" && req.PasswordCurrent != "" {
|
|
if req.PasswordNew == req.PasswordCurrent {
|
|
return errors.New("validation error: new password must be different")
|
|
}
|
|
}
|
|
|
|
// find user
|
|
u, err := s.userSvc.FindByUsername(ctx, req.UsernameCurrent)
|
|
if err != nil {
|
|
s.log.Trace().Err(err).Msgf("invalid login %v", req.UsernameCurrent)
|
|
return errors.Wrapf(err, "invalid login: %s", req.UsernameCurrent)
|
|
}
|
|
|
|
if u == nil {
|
|
return errors.Errorf("invalid login: %s", req.UsernameCurrent)
|
|
}
|
|
|
|
// compare password from request and the saved password
|
|
match, err := s.ComparePasswordAndHash(req.PasswordCurrent, u.Password)
|
|
if err != nil {
|
|
return errors.New("error checking credentials")
|
|
}
|
|
|
|
if !match {
|
|
s.log.Debug().Msgf("bad credentials: %q | %q", req.UsernameCurrent, req.PasswordCurrent)
|
|
return errors.Errorf("invalid login: %s", req.UsernameCurrent)
|
|
}
|
|
|
|
hashed, err := s.CreateHash(req.PasswordNew)
|
|
if err != nil {
|
|
return errors.New("failed to hash password")
|
|
}
|
|
|
|
req.PasswordNewHash = hashed
|
|
|
|
if err := s.userSvc.Update(ctx, req); err != nil {
|
|
s.log.Error().Err(err).Msgf("could not change password for user: %s", req.UsernameCurrent)
|
|
return errors.New("failed to change password")
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (s *service) ComparePasswordAndHash(password string, hash string) (match bool, err error) {
|
|
return argon2id.ComparePasswordAndHash(password, hash)
|
|
}
|
|
|
|
func (s *service) CreateHash(password string) (hash string, err error) {
|
|
return argon2id.CreateHash(password, argon2id.DefaultParams)
|
|
}
|