mirror of
https://github.com/idanoo/autobrr
synced 2025-07-23 16:59:12 +00:00

* refactor: this should be Debug() just like the rest. * feat: catch error when updating client table. Before if we provided the wrong ID it will just say it's successful when it shouldn't. * chore: handle the errors. * fix: defer tx.Rollback(). When I try handling the error we always hit the error no matter what even though there wasn't any error, This is due that defer block being executed unconditionally so even after we commit it successfully it will just give error. So add checking then commit it if all good. * feat: added testing env. This way we can use in memory sqlite. * chore: Delete log should be debug as well. * feat: enable foreign keys for testing for sqlite. I recommend enabling all together. Not sure why it's commented but for now will keep it the same and only enable for testing. * chore: catch error, if deleting a record fails. * chore: catch error, if deleting a record fails. * chore: catch error, when failed to enable toggle. * chore: catch error, if updating failed. * chore(filter): catch error, if deleting failed. * chore(filter): catch error, if row is not modified for ToggleEnabled. * chore(feed): Should be debug level to match with others. * chore(feed): catch error when nothing is updated. * chore: update docker-compose.yml add test_db for postgres. * chore(ci): update include postgres db service before running tests. * feat(database): Added database testing. * feat(database): Added api integration testing. * feat(database): Added action integration testing. * feat(database): Added download_client integration testing. * feat(database): Added filter integration testing. * test(database): initial tests model (WIP) * chore(feed): handle error when nothing is deleted. * tests(feed): added delete testing. * chore(feed): handle error when nothing is updated. * chore(feed): handle error when nothing is updated. * chore(feed): handle error when nothing is updated. * feat(database): Added feed integration testing. * fix(feed_cache): This should be time.Time not time.Duration. * chore(feed_cache): handle error when deleting fails. * feat(database): Added feed_cache integration testing. * chore: add EOL * feat: added indexer_test.go * feat: added mock irc data * fix: the column is not pass anymore it's password. * chore: added assertion. * fix: This is password column not pass test is failing because of it. * feat: added tests cases for irc. * feat: added test cases for release. * feat: added test cases for notifications. * feat: added Delete to the User DB that way it can be used for testing. * feat: added user database tests. * refactor: Make setupLogger and setupDatabase private also renamed them. Changed the visibility of `setupLogger` to private based on feedback. Also renamed the function to `setupLoggerForTest` and `setupDatabaseForTest` to make its purpose more descriptive. * fix(database): tests postgres ssl mode disable * refactor(database): setup and teardown --------- Co-authored-by: ze0s <43699394+zze0s@users.noreply.github.com>
368 lines
9.1 KiB
Go
368 lines
9.1 KiB
Go
// Copyright (c) 2021 - 2023, Ludvig Lundgren and the autobrr contributors.
|
|
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
package database
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"encoding/json"
|
|
"sync"
|
|
|
|
"github.com/autobrr/autobrr/internal/domain"
|
|
"github.com/autobrr/autobrr/internal/logger"
|
|
"github.com/autobrr/autobrr/pkg/errors"
|
|
|
|
sq "github.com/Masterminds/squirrel"
|
|
"github.com/rs/zerolog"
|
|
)
|
|
|
|
type DownloadClientRepo struct {
|
|
log zerolog.Logger
|
|
db *DB
|
|
cache *clientCache
|
|
}
|
|
|
|
type clientCache struct {
|
|
mu sync.RWMutex
|
|
clients map[int]*domain.DownloadClient
|
|
}
|
|
|
|
func NewClientCache() *clientCache {
|
|
return &clientCache{
|
|
clients: make(map[int]*domain.DownloadClient, 0),
|
|
}
|
|
}
|
|
|
|
func (c *clientCache) Set(id int, client *domain.DownloadClient) {
|
|
c.mu.Lock()
|
|
c.clients[id] = client
|
|
c.mu.Unlock()
|
|
}
|
|
|
|
func (c *clientCache) Get(id int) *domain.DownloadClient {
|
|
c.mu.RLock()
|
|
defer c.mu.RUnlock()
|
|
v, ok := c.clients[id]
|
|
if ok {
|
|
return v
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (c *clientCache) Pop(id int) {
|
|
c.mu.Lock()
|
|
delete(c.clients, id)
|
|
c.mu.Unlock()
|
|
}
|
|
|
|
func NewDownloadClientRepo(log logger.Logger, db *DB) domain.DownloadClientRepo {
|
|
return &DownloadClientRepo{
|
|
log: log.With().Str("repo", "action").Logger(),
|
|
db: db,
|
|
cache: NewClientCache(),
|
|
}
|
|
}
|
|
|
|
func (r *DownloadClientRepo) List(ctx context.Context) ([]domain.DownloadClient, error) {
|
|
clients := make([]domain.DownloadClient, 0)
|
|
|
|
queryBuilder := r.db.squirrel.
|
|
Select(
|
|
"id",
|
|
"name",
|
|
"type",
|
|
"enabled",
|
|
"host",
|
|
"port",
|
|
"tls",
|
|
"tls_skip_verify",
|
|
"username",
|
|
"password",
|
|
"settings",
|
|
).
|
|
From("client")
|
|
|
|
query, args, err := queryBuilder.ToSql()
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "error building query")
|
|
}
|
|
|
|
rows, err := r.db.handler.QueryContext(ctx, query, args...)
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "error executing query")
|
|
}
|
|
|
|
defer func(rows *sql.Rows) {
|
|
err := rows.Close()
|
|
if err != nil {
|
|
r.log.Error().Err(err).Msg("error closing rows")
|
|
}
|
|
}(rows)
|
|
|
|
for rows.Next() {
|
|
var f domain.DownloadClient
|
|
var settingsJsonStr string
|
|
|
|
if err := rows.Scan(&f.ID, &f.Name, &f.Type, &f.Enabled, &f.Host, &f.Port, &f.TLS, &f.TLSSkipVerify, &f.Username, &f.Password, &settingsJsonStr); err != nil {
|
|
return clients, errors.Wrap(err, "error scanning row")
|
|
}
|
|
|
|
if settingsJsonStr != "" {
|
|
if err := json.Unmarshal([]byte(settingsJsonStr), &f.Settings); err != nil {
|
|
return clients, errors.Wrap(err, "could not unmarshal download client settings: %v", settingsJsonStr)
|
|
}
|
|
}
|
|
|
|
clients = append(clients, f)
|
|
}
|
|
if err := rows.Err(); err != nil {
|
|
return clients, errors.Wrap(err, "rows error")
|
|
}
|
|
|
|
return clients, nil
|
|
}
|
|
|
|
func (r *DownloadClientRepo) FindByID(ctx context.Context, id int32) (*domain.DownloadClient, error) {
|
|
// get client from cache
|
|
c := r.cache.Get(int(id))
|
|
if c != nil {
|
|
return c, nil
|
|
}
|
|
|
|
queryBuilder := r.db.squirrel.
|
|
Select(
|
|
"id",
|
|
"name",
|
|
"type",
|
|
"enabled",
|
|
"host",
|
|
"port",
|
|
"tls",
|
|
"tls_skip_verify",
|
|
"username",
|
|
"password",
|
|
"settings",
|
|
).
|
|
From("client").
|
|
Where(sq.Eq{"id": id})
|
|
|
|
query, args, err := queryBuilder.ToSql()
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "error building query")
|
|
}
|
|
|
|
row := r.db.handler.QueryRowContext(ctx, query, args...)
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "error executing query")
|
|
}
|
|
|
|
var client domain.DownloadClient
|
|
var settingsJsonStr string
|
|
|
|
if err := row.Scan(&client.ID, &client.Name, &client.Type, &client.Enabled, &client.Host, &client.Port, &client.TLS, &client.TLSSkipVerify, &client.Username, &client.Password, &settingsJsonStr); err != nil {
|
|
if errors.Is(err, sql.ErrNoRows) {
|
|
return nil, errors.New("no client configured")
|
|
}
|
|
|
|
return nil, errors.Wrap(err, "error scanning row")
|
|
}
|
|
|
|
if settingsJsonStr != "" {
|
|
if err := json.Unmarshal([]byte(settingsJsonStr), &client.Settings); err != nil {
|
|
return nil, errors.Wrap(err, "could not unmarshal download client settings: %v", settingsJsonStr)
|
|
}
|
|
}
|
|
|
|
return &client, nil
|
|
}
|
|
|
|
func (r *DownloadClientRepo) Store(ctx context.Context, client domain.DownloadClient) (*domain.DownloadClient, error) {
|
|
var err error
|
|
|
|
settings := domain.DownloadClientSettings{
|
|
APIKey: client.Settings.APIKey,
|
|
Basic: client.Settings.Basic,
|
|
Rules: client.Settings.Rules,
|
|
ExternalDownloadClientId: client.Settings.ExternalDownloadClientId,
|
|
}
|
|
|
|
settingsJson, err := json.Marshal(&settings)
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "error marshal download client settings %+v", settings)
|
|
}
|
|
|
|
queryBuilder := r.db.squirrel.
|
|
Insert("client").
|
|
Columns("name", "type", "enabled", "host", "port", "tls", "tls_skip_verify", "username", "password", "settings").
|
|
Values(client.Name, client.Type, client.Enabled, client.Host, client.Port, client.TLS, client.TLSSkipVerify, client.Username, client.Password, settingsJson).
|
|
Suffix("RETURNING id").RunWith(r.db.handler)
|
|
|
|
// return values
|
|
var retID int
|
|
|
|
err = queryBuilder.QueryRowContext(ctx).Scan(&retID)
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "error executing query")
|
|
}
|
|
|
|
client.ID = retID
|
|
|
|
r.log.Debug().Msgf("download_client.store: %d", client.ID)
|
|
|
|
// save to cache
|
|
r.cache.Set(client.ID, &client)
|
|
|
|
return &client, nil
|
|
}
|
|
|
|
func (r *DownloadClientRepo) Update(ctx context.Context, client domain.DownloadClient) (*domain.DownloadClient, error) {
|
|
var err error
|
|
|
|
settings := domain.DownloadClientSettings{
|
|
APIKey: client.Settings.APIKey,
|
|
Basic: client.Settings.Basic,
|
|
Rules: client.Settings.Rules,
|
|
ExternalDownloadClientId: client.Settings.ExternalDownloadClientId,
|
|
}
|
|
|
|
settingsJson, err := json.Marshal(&settings)
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "error marshal download client settings %+v", settings)
|
|
}
|
|
|
|
queryBuilder := r.db.squirrel.
|
|
Update("client").
|
|
Set("name", client.Name).
|
|
Set("type", client.Type).
|
|
Set("enabled", client.Enabled).
|
|
Set("host", client.Host).
|
|
Set("port", client.Port).
|
|
Set("tls", client.TLS).
|
|
Set("tls_skip_verify", client.TLSSkipVerify).
|
|
Set("username", client.Username).
|
|
Set("password", client.Password).
|
|
Set("settings", string(settingsJson)).
|
|
Where(sq.Eq{"id": client.ID})
|
|
|
|
query, args, err := queryBuilder.ToSql()
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "error building query")
|
|
}
|
|
|
|
result, err := r.db.handler.ExecContext(ctx, query, args...)
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "error executing query")
|
|
}
|
|
|
|
rowsAffected, err := result.RowsAffected()
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "error getting rows affected")
|
|
}
|
|
|
|
if rowsAffected == 0 {
|
|
return nil, errors.New("no rows updated")
|
|
}
|
|
|
|
r.log.Debug().Msgf("download_client.update: %d", client.ID)
|
|
|
|
// save to cache
|
|
r.cache.Set(client.ID, &client)
|
|
|
|
return &client, nil
|
|
}
|
|
|
|
func (r *DownloadClientRepo) Delete(ctx context.Context, clientID int) error {
|
|
tx, err := r.db.BeginTx(ctx, &sql.TxOptions{})
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
defer func() {
|
|
var txErr error
|
|
if p := recover(); p != nil {
|
|
txErr = tx.Rollback()
|
|
if txErr != nil {
|
|
r.log.Error().Err(txErr).Msg("error rolling back transaction")
|
|
}
|
|
r.log.Error().Msgf("something went terribly wrong panic: %v", p)
|
|
} else if err != nil {
|
|
txErr = tx.Rollback()
|
|
if txErr != nil {
|
|
r.log.Error().Err(txErr).Msg("error rolling back transaction")
|
|
}
|
|
} else {
|
|
// All good, commit
|
|
txErr = tx.Commit()
|
|
if txErr != nil {
|
|
r.log.Error().Err(txErr).Msg("error committing transaction")
|
|
}
|
|
}
|
|
}()
|
|
|
|
if err = r.delete(ctx, tx, clientID); err != nil {
|
|
return errors.Wrap(err, "error deleting download client: %d", clientID)
|
|
}
|
|
|
|
if err = r.deleteClientFromAction(ctx, tx, clientID); err != nil {
|
|
return errors.Wrap(err, "error deleting download client: %d", clientID)
|
|
}
|
|
|
|
r.log.Debug().Msgf("delete download client: %d", clientID)
|
|
return nil
|
|
}
|
|
|
|
func (r *DownloadClientRepo) delete(ctx context.Context, tx *Tx, clientID int) error {
|
|
queryBuilder := r.db.squirrel.
|
|
Delete("client").
|
|
Where(sq.Eq{"id": clientID})
|
|
|
|
query, args, err := queryBuilder.ToSql()
|
|
if err != nil {
|
|
return errors.Wrap(err, "error building query")
|
|
}
|
|
|
|
res, err := tx.ExecContext(ctx, query, args...)
|
|
if err != nil {
|
|
return errors.Wrap(err, "error executing query")
|
|
}
|
|
|
|
// remove from cache
|
|
r.cache.Pop(clientID)
|
|
|
|
rows, _ := res.RowsAffected()
|
|
if rows == 0 {
|
|
return errors.New("no rows affected")
|
|
}
|
|
|
|
r.log.Debug().Msgf("delete download client: %d", clientID)
|
|
|
|
return nil
|
|
}
|
|
|
|
func (r *DownloadClientRepo) deleteClientFromAction(ctx context.Context, tx *Tx, clientID int) error {
|
|
var err error
|
|
|
|
queryBuilder := r.db.squirrel.
|
|
Update("action").
|
|
Set("enabled", false).
|
|
Set("client_id", 0).
|
|
Where(sq.Eq{"client_id": clientID}).
|
|
Suffix("RETURNING filter_id").RunWith(tx)
|
|
|
|
// return values
|
|
var filterID int
|
|
|
|
if err = queryBuilder.QueryRowContext(ctx).Scan(&filterID); err != nil {
|
|
// this will throw when the client is not connected to any actions
|
|
// it is not an error in this case
|
|
if errors.Is(err, sql.ErrNoRows) {
|
|
return nil
|
|
}
|
|
return errors.Wrap(err, "error executing query")
|
|
}
|
|
|
|
r.log.Debug().Msgf("deleting download client %d from action for filter %d", clientID, filterID)
|
|
|
|
return nil
|
|
}
|