fix(server): exclude tags from version check (#382)

This commit is contained in:
ze0s 2022-07-29 15:21:55 +02:00 committed by GitHub
parent 6196dcaab9
commit ab8f25d56f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 33 additions and 1 deletions

View file

@ -65,7 +65,7 @@ func (c *Checker) get(ctx context.Context) (*Release, error) {
} }
func (c *Checker) CheckNewVersion(ctx context.Context, version string) (bool, string, error) { func (c *Checker) CheckNewVersion(ctx context.Context, version string) (bool, string, error) {
if version == "dev" { if isDevelop(version) {
return false, "", nil return false, "", nil
} }
@ -99,3 +99,15 @@ func (c *Checker) checkNewVersion(version string, release *Release) (bool, strin
return false, "", nil return false, "", nil
} }
func isDevelop(version string) bool {
tags := []string{"dev", "develop", "master", "latest"}
for _, tag := range tags {
if version == tag {
return true
}
}
return false
}

View file

@ -107,3 +107,23 @@ func TestGitHubReleaseChecker_checkNewVersion(t *testing.T) {
}) })
} }
} }
func Test_isDevelop(t *testing.T) {
tests := []struct {
name string
version string
want bool
}{
{name: "test_1", version: "dev", want: true},
{name: "test_2", version: "develop", want: true},
{name: "test_3", version: "master", want: true},
{name: "test_4", version: "latest", want: true},
{name: "test_5", version: "v1.0.1", want: false},
{name: "test_6", version: "1.0.1", want: false},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
assert.Equalf(t, tt.want, isDevelop(tt.version), "isDevelop(%v)", tt.version)
})
}
}