idanoo/autobrr
1
0
Fork 0
mirror of https://github.com/idanoo/autobrr synced 2025-07-24 09:19:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(database): SQLite try reindexing on integrity check error (#1877)

Browse source 
* fix(database): SQLite try reindexing on consistency error

* fix(database): SQLite return err if no bad indexes found
This commit is contained in:
ze0s 2024-12-14 15:58:18 +01:00 • committed by GitHub
parent 66fa645625
commit 96f61a90e5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 75 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

78
internal/database/sqlite.go
View file

@ -271,17 +271,89 @@ func customMigrateCopySourcesToMedia(tx *sql.Tx) error {
func (db *DB) databaseConsistencyCheckSQLite() error {
db.log.Info().Msg("Database integrity check..")
rows, err := db.handler.Query("PRAGMA integrity_check;")
if err != nil {
return errors.Wrap(err, "failed to query integrity check")
}
var results []string
for rows.Next() {
var result string
if err := rows.Scan(&result); err != nil {
return errors.Wrap(err, "backup integrity unexpected state")
}
results = append(results, result)
}
if err := rows.Err(); err != nil {
return errors.Wrap(err, "backup integrity unexpected state")
}
if len(results) == 1 && results[0] == "ok" {
db.log.Info().Msg("Database integrity check OK!")
return nil
}
if err := db.sqlitePerformReIndexing(results); err != nil {
return errors.Wrap(err, "failed to reindex database")
}
db.log.Info().Msg("Database integrity check post re-indexing..")
row := db.handler.QueryRow("PRAGMA integrity_check;")
var status string
if err := row.Scan(&status); err != nil {
return errors.Wrap(err, "backup integrity unexpected state")
}
db.log.Info().Msgf("Database integrity check: %s", status)
if status != "ok" {
return errors.New("backup integrity check failed: %q", status)
}
db.log.Info().Msg("Database integrity check OK!")
return nil
}
// sqlitePerformReIndexing try to reindex bad indexes
func (db *DB) sqlitePerformReIndexing(results []string) error {
db.log.Warn().Msg("Database integrity check failed!")
db.log.Info().Msg("Backing up database before re-indexing..")
if err := db.backupSQLiteDatabase(); err != nil {
return errors.Wrap(err, "failed to create database backup")
}
db.log.Info().Msg("Database backup created!")
var badIndexes []string
for _, issue := range results {
index, found := strings.CutPrefix(issue, "wrong # of entries in index ")
if found {
db.log.Warn().Msgf("Database integrity check failed on index: %s", index)
badIndexes = append(badIndexes, index)
}
}
if len(badIndexes) == 0 {
return errors.New("found no indexes to reindex")
}
for _, index := range badIndexes {
db.log.Info().Msgf("Database attempt to re-index: %s", index)
_, err := db.handler.Exec(fmt.Sprintf("REINDEX %s;", index))
if err != nil {
return errors.Wrap(err, "failed to backup database")
}
}
db.log.Info().Msg("Database re-indexing OK!")
return nil
}
@ -331,7 +403,7 @@ func (db *DB) cleanupSQLiteBackups() error {
timestamp := strings.TrimSuffix(parts[2], ".backup")
if _, err := time.Parse(timeFormat, timestamp); err == nil {
backups = append(backups, file.Name())
} else if _, err := time.Parse(badFormat, timestamp); err == nil {
} else if _, err := time.Parse(badFormat, timestamp); err == nil {
broken = append(broken, file.Name())
}
}
@ -356,7 +428,7 @@ func (db *DB) cleanupSQLiteBackups() error {
if err := os.Remove(filepath.Join(backupDir, broken[i])); err != nil {
return errors.Wrap(err, "failed to remove old backups")
}
db.log.Info().Msgf("Removed Old SQLite backup: %s", broken[i])
}