fix(actions): reject if client is disabled (#1626)

* fix(actions): error on disabled client

* fix(actions): sql scan args

* refactor: download client cache for actions

* fix: tests client store

* fix: tests client store and int conversion

* fix: tests revert findbyid ctx timeout

* fix: tests row.err

* feat: add logging to download client cache

internal/domain/action.go

@@ -14,7 +14,7 @@ import (
 type ActionRepo interface {
 	Store(ctx context.Context, action Action) (*Action, error)
 	StoreFilterActions(ctx context.Context, filterID int64, actions []*Action) ([]*Action, error)
-	FindByFilterID(ctx context.Context, filterID int, active *bool) ([]*Action, error)
+	FindByFilterID(ctx context.Context, filterID int, active *bool, withClient bool) ([]*Action, error)
 	List(ctx context.Context) ([]Action, error)
 	Get(ctx context.Context, req *GetActionRequest) (*Action, error)
 	Delete(ctx context.Context, req *DeleteActionRequest) error

internal/domain/client.go

@@ -9,20 +9,18 @@ import (
 	"net/url"
 
 	"github.com/autobrr/autobrr/pkg/errors"
-
-	"github.com/autobrr/go-qbittorrent"
 )
 
 type DownloadClientRepo interface {
 	List(ctx context.Context) ([]DownloadClient, error)
 	FindByID(ctx context.Context, id int32) (*DownloadClient, error)
-	Store(ctx context.Context, client DownloadClient) (*DownloadClient, error)
-	Update(ctx context.Context, client DownloadClient) (*DownloadClient, error)
-	Delete(ctx context.Context, clientID int) error
+	Store(ctx context.Context, client *DownloadClient) error
+	Update(ctx context.Context, client *DownloadClient) error
+	Delete(ctx context.Context, clientID int32) error
 }
 
 type DownloadClient struct {
-	ID            int                    `json:"id"`
+	ID            int32                  `json:"id"`
 	Name          string                 `json:"name"`
 	Type          DownloadClientType     `json:"type"`
 	Enabled       bool                   `json:"enabled"`
@@ -33,11 +31,9 @@ type DownloadClient struct {
 	Username      string                 `json:"username"`
 	Password      string                 `json:"password"`
 	Settings      DownloadClientSettings `json:"settings,omitempty"`
-}
 
-type DownloadClientCached struct {
-	Dc  *DownloadClient
-	Qbt *qbittorrent.Client
+	// cached http client
+	Client any
 }
 
 type DownloadClientSettings struct {

internal/domain/client_test.go

@@ -11,7 +11,7 @@ import (
 
 func TestDownloadClient_qbitBuildLegacyHost(t *testing.T) {
 	type fields struct {
-		ID            int
+		ID            int32
 		Name          string
 		Type          DownloadClientType
 		Enabled       bool