idanoo/autobrr
1
0
Fork 0
mirror of https://github.com/idanoo/autobrr synced 2025-07-23 16:59:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat(irc): log connection errors (#1239)

Browse source 
* add logline for failed connection

* modify logging, change debug -> error

* don't surface "client called Quit" errors

* irc: don't retry Connect() while stopped

* fix issue number

* don't unlock until state-change complete

* Revert "don't unlock until state-change complete"

This reverts commit bf107db99bc2758b729a5995c63067f8fdf16aec.

---------

Co-authored-by: Shivaram Lingamneni <slingamn@cs.stanford.edu>
This commit is contained in:
Frederick Robinson 2023-11-18 06:44:46 -08:00 • committed by GitHub
parent fef0da5711
commit 7cb2aaa8a5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

14
internal/irc/handler.go
View file

@ -25,6 +25,10 @@ import (
"github.com/sasha-s/go-deadlock"
)
var (
clientManuallyDisconnected = retry.Unrecoverable(errors.New("IRC client was manually disconnected"))
)
type channelHealth struct {
m deadlock.RWMutex
@ -219,7 +223,17 @@ func (h *Handler) Run() error {
func() error {
h.log.Debug().Msgf("connect attempt %d", connectAttempts)
// #1239: don't retry if the user manually disconnected with Stop()
h.m.RLock()
manuallyDisconnected := h.manuallyDisconnected
h.m.RUnlock()
if manuallyDisconnected {
return clientManuallyDisconnected
}
if err := h.client.Connect(); err != nil {
h.log.Error().Err(err).Msg("client encountered connection error")
connectAttempts++
return err
}