fix(web): tooltips (#1154)

* fix broken tooltips, replace react-tooltip with react-popper-tooltip

* make tooltips use ExternalLink component

* fix import

* get rid of unused import

* fix(tooltip): set delayHide

* removed unecessary comment

* fix tooltip on mobile

* stop tooltip label propagation (mainly for mobile devices)

* added onClick convenience prop for label component wrapper (since onClick isn't propagated down)

---------

Co-authored-by: soup <soup@r4tio.dev>

web/src/screens/settings/Application.tsx

@@ -11,6 +11,7 @@ import { Checkbox } from "@components/Checkbox";
 import { SettingsContext } from "@utils/Context";
 import { GithubRelease } from "@app/types/Update";
 import Toast from "@components/notifications/Toast";
+import { ExternalLink } from "@components/ExternalLink";
 
 interface RowItemProps {
   label: string;
@@ -63,9 +64,12 @@ const RowItemVersion = ({ label, value, title, newUpdate }: RowItemProps) => {
       <dd className="mt-1 text-gray-900 dark:text-gray-300 text-sm sm:mt-0 sm:col-span-2 break-all truncate">
         <span className="px-1.5 py-1 bg-gray-200 dark:bg-gray-700 rounded shadow">{value}</span>
         {newUpdate && newUpdate.html_url && (
-          <span>
-            <a href={newUpdate.html_url} target="_blank" rel="noopener noreferrer"><span className="ml-2 inline-flex items-center rounded-md bg-green-100 px-2.5 py-0.5 text-sm font-medium text-green-800">{newUpdate.name} available!</span></a>
-          </span>
+          <ExternalLink
+            href={newUpdate.html_url}
+            className="ml-2 inline-flex items-center rounded-md bg-green-100 px-2.5 py-0.5 text-sm font-medium text-green-800"
+          >
+            {newUpdate.name} available!
+          </ExternalLink>
         )}
       </dd>
     </div>
@@ -184,10 +188,12 @@ function ApplicationSettings() {
             <Checkbox
               label="WebUI Debug mode"
               value={settings.debug}
-              setValue={(newValue: boolean) => setSettings({
-                ...settings,
-                debug: newValue
-              })}
+              setValue={
+                (newValue: boolean) => setSettings((prevState) => ({
+                  ...prevState,
+                  debug: newValue
+                }))
+              }
             />
           </div>
           <div className="px-4 sm:px-6 py-1">
@@ -205,15 +211,16 @@ function ApplicationSettings() {
               label="Dark theme"
               description="Switch between dark and light theme."
               value={settings.darkTheme}
-              setValue={(newValue: boolean) => setSettings({
-                ...settings,
-                darkTheme: newValue
-              })}
+              setValue={
+                (newValue: boolean) => setSettings((prevState) => ({
+                  ...prevState,
+                  darkTheme: newValue
+                }))
+              }
             />
           </div>
         </ul>
       </div>
-
     </div>
   );
 }

web/src/screens/settings/Feed.tsx

@@ -24,6 +24,7 @@ import { FeedUpdateForm } from "@forms/settings/FeedForms";
 import { EmptySimple } from "@components/emptystates";
 import { ImplementationBadges } from "./Indexer";
 import { ArrowPathIcon } from "@heroicons/react/24/solid";
+import { ExternalLink } from "@components/ExternalLink";
 
 export const feedKeys = {
   all: ["feeds"] as const,
@@ -354,10 +355,8 @@ const FeedItemDropdown = ({
           <div>
             <Menu.Item>
               {({ active }) => (
-                <a
+                <ExternalLink
                   href={`${baseUrl()}api/feeds/${feed.id}/latest`}
-                  target="_blank"
-                  rel="noopener noreferrer"
                   className={classNames(
                     active ? "bg-blue-600 text-white" : "text-gray-900 dark:text-gray-300",
                     "font-medium group flex rounded-md items-center w-full px-2 py-2 text-sm"
@@ -371,7 +370,7 @@ const FeedItemDropdown = ({
                     aria-hidden="true"
                   />
                   View latest run
-                </a>
+                </ExternalLink>
               )}
             </Menu.Item>
             <Menu.Item>