idanoo/autobrr
1
0
Fork 0
mirror of https://github.com/idanoo/autobrr synced 2025-07-23 16:59:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

enhancement(database): improve log messages (#695)

Browse source 
* fix(migrations): reduce anxiety anxiety

* sqlite
This commit is contained in:
Kyle Sanderson 2023-02-11 13:32:22 -08:00 • committed by GitHub
parent e20219170e
commit 3b516c8bcc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

10
internal/database/postgres.go
View file

@ -51,15 +51,16 @@ func (db *DB) migratePostgres() error {
var version int var version int
err = tx.QueryRow(`SELECT version FROM schema_migrations`).Scan(&version) err = tx.QueryRow(`SELECT version FROM schema_migrations`).Scan(&version)
if err != nil && !errors.Is(err, sql.ErrNoRows) { if err != nil && !errors.Is(err, sql.ErrNoRows) {
return errors.Wrap(err, "no rows") return errors.Wrap(err, "failed to query schema version")
} }
if version == len(postgresMigrations) { if version == len(postgresMigrations) {
return nil return nil
} else if version > len(postgresMigrations) {
return errors.New("autobrr (version %d) older than schema (version: %d)", len(postgresMigrations), version)
} }
if version > len(postgresMigrations) {
return errors.New("old") db.log.Info().Msgf("Beginning database schema upgrade from version %v to version: %v", version, len(postgresMigrations))
}
if version == 0 { if version == 0 {
if _, err := tx.Exec(postgresSchema); err != nil { if _, err := tx.Exec(postgresSchema); err != nil {
@ -67,6 +68,7 @@ func (db *DB) migratePostgres() error {
} }
} else { } else {
for i := version; i < len(postgresMigrations); i++ { for i := version; i < len(postgresMigrations); i++ {
db.log.Info().Msgf("Upgrading Database schema to version: %v", i)
if _, err := tx.Exec(postgresMigrations[i]); err != nil { if _, err := tx.Exec(postgresMigrations[i]); err != nil {
return errors.Wrap(err, "failed to execute migration #%v", i) return errors.Wrap(err, "failed to execute migration #%v", i)
} }

3
internal/database/sqlite.go
View file

@ -65,6 +65,8 @@ func (db *DB) migrateSQLite() error {
return errors.New("autobrr (version %d) older than schema (version: %d)", len(sqliteMigrations), version) return errors.New("autobrr (version %d) older than schema (version: %d)", len(sqliteMigrations), version)
} }
db.log.Info().Msgf("Beginning database schema upgrade from version %v to version: %v", version, len(sqliteMigrations))
tx, err := db.handler.Begin() tx, err := db.handler.Begin()
if err != nil { if err != nil {
return err return err
@ -77,6 +79,7 @@ func (db *DB) migrateSQLite() error {
} }
} else { } else {
for i := version; i < len(sqliteMigrations); i++ { for i := version; i < len(sqliteMigrations); i++ {
db.log.Info().Msgf("Upgrading Database schema to version: %v", i)
if _, err := tx.Exec(sqliteMigrations[i]); err != nil { if _, err := tx.Exec(sqliteMigrations[i]); err != nil {
return errors.Wrap(err, "failed to execute migration #%v", i) return errors.Wrap(err, "failed to execute migration #%v", i)
} }