idanoo/autobrr
1
0
Fork 0
mirror of https://github.com/idanoo/autobrr synced 2025-07-23 08:49:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(tags): 24bit Lossless being tagged as Lossless (#743)

Browse source 
* fix(tags): fixed `24bit Lossless` being tagged as `Lossless`

added negation to the Lossless regex to prevent it from matching 24bit Lossless

* fix(tests): modified test to reflect changes in regex
This commit is contained in:
nuxen 2023-03-07 19:50:38 +01:00 • committed by GitHub
parent cec6809b34
commit 371943d144
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
internal/domain/release_test.go
View file

@ -220,7 +220,7 @@ func TestRelease_Parse(t *testing.T) {
ReleaseTags: "FLAC / 24bit Lossless / Log / 100% / Cue / CD", ReleaseTags: "FLAC / 24bit Lossless / Log / 100% / Cue / CD",
Title: "Artist", Title: "Artist",
Group: "Albumname", Group: "Albumname",
Audio: []string{"24BIT Lossless", "Cue", "FLAC", "Lossless", "Log100", "Log"}, Audio: []string{"24BIT Lossless", "Cue", "FLAC", "Log100", "Log"},
Source: "CD", Source: "CD",
}, },
}, },

2
internal/domain/releasetags.go
View file

@ -42,7 +42,7 @@ func init() {
{tag: "EX", title: "Dolby Digital (EX)", regexp: "(?-i:EX)", re: nil}, {tag: "EX", title: "Dolby Digital (EX)", regexp: "(?-i:EX)", re: nil},
{tag: "FLAC", title: "Free Lossless Audio Codec", regexp: "", re: nil}, {tag: "FLAC", title: "Free Lossless Audio Codec", regexp: "", re: nil},
{tag: "LiNE", title: "Line", regexp: "(?-i:L[iI]NE)", re: nil}, {tag: "LiNE", title: "Line", regexp: "(?-i:L[iI]NE)", re: nil},
{tag: "Lossless", title: "", regexp: "(?i:Lossless)", re: nil}, {tag: "Lossless", title: "", regexp: "(?i:(?:^|[^t] )Lossless)", re: nil},
{tag: "Log100", title: "", regexp: "(log 100%|log \\(100%\\))", re: nil}, {tag: "Log100", title: "", regexp: "(log 100%|log \\(100%\\))", re: nil},
{tag: "Log", title: "", regexp: "(?:log)", re: nil}, {tag: "Log", title: "", regexp: "(?:log)", re: nil},
{tag: "LPCM", title: "Linear Pulse-Code Modulation", regexp: "", re: nil}, {tag: "LPCM", title: "Linear Pulse-Code Modulation", regexp: "", re: nil},

2
internal/domain/releasetags_test.go
View file

@ -37,7 +37,7 @@ func TestParseReleaseTagString(t *testing.T) {
{name: "music_1", args: args{tags: "FLAC / Lossless / Log / 80% / Cue / CD"}, want: ReleaseTags{Audio: []string{"Cue", "FLAC", "Lossless", "Log"}, Source: "CD"}}, {name: "music_1", args: args{tags: "FLAC / Lossless / Log / 80% / Cue / CD"}, want: ReleaseTags{Audio: []string{"Cue", "FLAC", "Lossless", "Log"}, Source: "CD"}},
{name: "music_2", args: args{tags: "FLAC Lossless Log 80% Cue CD"}, want: ReleaseTags{Audio: []string{"Cue", "FLAC", "Lossless", "Log"}, Source: "CD"}}, {name: "music_2", args: args{tags: "FLAC Lossless Log 80% Cue CD"}, want: ReleaseTags{Audio: []string{"Cue", "FLAC", "Lossless", "Log"}, Source: "CD"}},
{name: "music_3", args: args{tags: "FLAC Lossless Log 100% Cue CD"}, want: ReleaseTags{Audio: []string{"Cue", "FLAC", "Lossless", "Log100", "Log"}, Source: "CD"}}, {name: "music_3", args: args{tags: "FLAC Lossless Log 100% Cue CD"}, want: ReleaseTags{Audio: []string{"Cue", "FLAC", "Lossless", "Log100", "Log"}, Source: "CD"}},
{name: "music_4", args: args{tags: "FLAC 24bit Lossless Log 100% Cue CD"}, want: ReleaseTags{Audio: []string{"24BIT Lossless", "Cue", "FLAC", "Lossless", "Log100", "Log"}, Source: "CD"}}, {name: "music_4", args: args{tags: "FLAC 24bit Lossless Log 100% Cue CD"}, want: ReleaseTags{Audio: []string{"24BIT Lossless", "Cue", "FLAC", "Log100", "Log"}, Source: "CD"}},
{name: "music_5", args: args{tags: "MP3 320 WEB"}, want: ReleaseTags{Audio: []string{"320", "MP3"}, Source: "WEB"}}, {name: "music_5", args: args{tags: "MP3 320 WEB"}, want: ReleaseTags{Audio: []string{"320", "MP3"}, Source: "WEB"}},
{name: "music_6", args: args{tags: "FLAC Lossless Log (100%) Cue CD"}, want: ReleaseTags{Audio: []string{"Cue", "FLAC", "Lossless", "Log100", "Log"}, Source: "CD"}}, {name: "music_6", args: args{tags: "FLAC Lossless Log (100%) Cue CD"}, want: ReleaseTags{Audio: []string{"Cue", "FLAC", "Lossless", "Log100", "Log"}, Source: "CD"}},
{name: "movies_1", args: args{tags: "x264 Blu-ray MKV 1080p"}, want: ReleaseTags{Codec: "x264", Source: "BluRay", Resolution: "1080p", Container: "mkv"}}, {name: "movies_1", args: args{tags: "x264 Blu-ray MKV 1080p"}, want: ReleaseTags{Codec: "x264", Source: "BluRay", Resolution: "1080p", Container: "mkv"}},