feat(indexers): add support for optional baseurl override (#551)

* feat(indexers): optional baseurl override

* feat(indexers): update baseUrl parsing

* refactor(indexers): BREAKING move parse to IRC struct

* Move Parse as part of IRC struct from Indexer
* Updated definitions
* Build torrentUrl in stages
* Use new url.JoinPath to build torrentUrl
* Update tests

* refactor(indexers): select option obj

* refactor(indexers): make backwards compatible

internal/indexer/definitions/ncore.yaml

@@ -4,7 +4,7 @@ identifier: ncore
 description: nCore
 language: en-us
 urls:
-  - https://ncore.pro
+  - https://ncore.pro/
 privacy: private
 protocol: torrent
 supports:
@@ -53,20 +53,20 @@ irc:
       label: Invite command
       help: Invite auth with the key from https://ncore.pro/irc.php. Replace IRCKEY
 
-parse:
-  type: single
-  lines:
-    - test:
-        - "[NEW TORRENT in mp3] Artist name - Album name > 115.63 MiB in 17F > https://ncore.pro/torrents.php?action=details&id=0000000"
-        - "[NEW TORRENT in xvidser_hun] Some.Show.S02E67.RTLM.WEB-DL.H264.HUN-GROUP > 269.31 MiB in 2F > https://ncore.pro/torrents.php?action=details&id=0000000"
-      pattern: '\[NEW TORRENT in (.*)\] (.*) > (.*) in .* > (https?://ncore.pro.*action=).*id=(.*)'
-      vars:
-        - category
-        - torrentName
-        - torrentSize
-        - baseUrl
-        - torrentId
+  parse:
+    type: single
+    lines:
+      - test:
+          - "[NEW TORRENT in mp3] Artist name - Album name > 115.63 MiB in 17F > https://ncore.pro/torrents.php?action=details&id=0000000"
+          - "[NEW TORRENT in xvidser_hun] Some.Show.S02E67.RTLM.WEB-DL.H264.HUN-GROUP > 269.31 MiB in 2F > https://ncore.pro/torrents.php?action=details&id=0000000"
+        pattern: '\[NEW TORRENT in (.*)\] (.*) > (.*) in .* > (https?://ncore.pro.*action=).*id=(.*)'
+        vars:
+          - category
+          - torrentName
+          - torrentSize
+          - baseUrl
+          - torrentId
 
-  match:
-    # https://ncore.pro/torrents.php?action=download&id=0000&key=00000
-    torrenturl: "{{ .baseUrl }}download&id={{ .torrentId }}&key={{ .passkey }}"
+    match:
+      # https://ncore.pro/torrents.php?action=download&id=0000&key=00000
+      torrenturl: "/download&id={{ .torrentId }}&key={{ .passkey }}"