From 1215036d8956b75a7c3a89042df7bdc3470576fd Mon Sep 17 00:00:00 2001
From: stacksmash76 <98354295+stacksmash76@users.noreply.github.com>
Date: Sun, 10 Sep 2023 17:50:24 +0200
Subject: [PATCH] fix(web): actions ratio limit support decimal values (#1100)

fix(web): make NumberField support decimal values
---
 web/src/components/inputs/input.tsx | 12 +++++++++---
 web/src/screens/filters/Action.tsx  |  3 ++-
 2 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/web/src/components/inputs/input.tsx b/web/src/components/inputs/input.tsx
index 6ec51a2..cf795fe 100644
--- a/web/src/components/inputs/input.tsx
+++ b/web/src/components/inputs/input.tsx
@@ -609,6 +609,7 @@ interface NumberFieldProps {
   min?: number;
   max?: number;
   tooltip?: JSX.Element;
+  isDecimal?: boolean;
 }
 
 export const NumberField = ({
@@ -620,7 +621,8 @@ export const NumberField = ({
   max,
   tooltip,
   disabled,
-  required
+  required,
+  isDecimal
 }: NumberFieldProps) => (
   <div className="col-span-12 sm:col-span-6">
     <label
@@ -642,7 +644,7 @@ export const NumberField = ({
             step={step}
             min={min}
             max={max}
-            inputMode="numeric"
+            inputMode={isDecimal ? "decimal" : "numeric"}
             required={required}
             className={classNames(
               meta.touched && meta.error
@@ -660,7 +662,11 @@ export const NumberField = ({
                 form.setFieldValue(field.name, 0);
                 return;
               }
-              form.setFieldValue(field.name, parseInt(event.target.value)); // Convert the input value to an integer using parseInt() to ensure that the backend can properly parse the numberfield as an integer.
+              if (isDecimal) {
+                form.setFieldValue(field.name, parseFloat(event.target.value));
+              } else {
+                form.setFieldValue(field.name, parseInt(event.target.value));
+              }
             }}
             onWheel={(event) => {
               if (event.currentTarget === document.activeElement) {
diff --git a/web/src/screens/filters/Action.tsx b/web/src/screens/filters/Action.tsx
index a49d92f..dab86a7 100644
--- a/web/src/screens/filters/Action.tsx
+++ b/web/src/screens/filters/Action.tsx
@@ -263,7 +263,8 @@ const TypeForm = ({ action, idx, clients }: TypeFormProps) => {
                 name={`actions.${idx}.limit_ratio`}
                 label="Ratio limit"
                 placeholder="Takes any number (0 is no limit)"
-                step={1} // 0.5 does not work
+                step={0.25}
+                isDecimal
               />
               <NumberField
                 name={`actions.${idx}.limit_seed_time`}