From 0af95e2b44b5e6fe04ef2d8d1eb9ba115137954d Mon Sep 17 00:00:00 2001
From: ze0s <43699394+zze0s@users.noreply.github.com>
Date: Tue, 17 Jan 2023 21:35:31 +0100
Subject: [PATCH] feat(logging): make log size and log backups configurable
 (#657)

feat(logging): make log size and backups configurable
---
 config.toml               | 16 ++++++++++++++++
 internal/config/config.go | 18 ++++++++++++++++++
 internal/domain/config.go |  2 ++
 internal/logger/logger.go |  4 ++--
 4 files changed, 38 insertions(+), 2 deletions(-)

diff --git a/config.toml b/config.toml
index 90d8fc2..8de3375 100644
--- a/config.toml
+++ b/config.toml
@@ -35,6 +35,22 @@ port = 7474
 #
 logLevel = "TRACE"
 
+# Log Max Size
+#
+# Default: 50
+#
+# Max log size in megabytes
+#
+#logMaxSize = 50
+
+# Log Max Backups
+#
+# Default: 3
+#
+# Max amount of old log files
+#
+#logMaxBackups = 3
+
 # Session secret
 #
 sessionSecret = "secret-session-key"
diff --git a/internal/config/config.go b/internal/config/config.go
index c658896..c353b05 100644
--- a/internal/config/config.go
+++ b/internal/config/config.go
@@ -56,6 +56,22 @@ port = 7474
 #
 logLevel = "DEBUG"
 
+# Log Max Size
+#
+# Default: 50
+#
+# Max log size in megabytes
+#
+#logMaxSize = 50
+
+# Log Max Backups
+#
+# Default: 3
+#
+# Max amount of old log files
+#
+#logMaxBackups = 3
+
 # Session secret
 #
 sessionSecret = "{{ .sessionSecret }}"
@@ -158,6 +174,8 @@ func (c *AppConfig) defaults() {
 		Port:              7474,
 		LogLevel:          "TRACE",
 		LogPath:           "",
+		LogMaxSize:        50,
+		LogMaxBackups:     3,
 		BaseURL:           "/",
 		SessionSecret:     "secret-session-key",
 		CustomDefinitions: "",
diff --git a/internal/domain/config.go b/internal/domain/config.go
index ff615bd..1473b59 100644
--- a/internal/domain/config.go
+++ b/internal/domain/config.go
@@ -7,6 +7,8 @@ type Config struct {
 	Port              int    `toml:"port"`
 	LogLevel          string `toml:"logLevel"`
 	LogPath           string `toml:"logPath"`
+	LogMaxSize        int    `toml:"logMaxSize"`
+	LogMaxBackups     int    `toml:"logMaxBackups"`
 	BaseURL           string `toml:"baseUrl"`
 	SessionSecret     string `toml:"sessionSecret"`
 	CustomDefinitions string `toml:"customDefinitions"`
diff --git a/internal/logger/logger.go b/internal/logger/logger.go
index 9f57a20..17f7141 100644
--- a/internal/logger/logger.go
+++ b/internal/logger/logger.go
@@ -59,8 +59,8 @@ func New(cfg *domain.Config) Logger {
 		l.writers = append(l.writers,
 			&lumberjack.Logger{
 				Filename:   cfg.LogPath,
-				MaxSize:    50, // megabytes
-				MaxBackups: 3,
+				MaxSize:    cfg.LogMaxSize, // megabytes
+				MaxBackups: cfg.LogMaxBackups,
 			},
 		)
 	}