mirror of
https://github.com/idanoo/GoScrobble.git
synced 2024-11-24 09:25:15 +00:00
356 lines
11 KiB
JavaScript
356 lines
11 KiB
JavaScript
/**
|
|
* @fileoverview Enforces consistent naming for boolean props
|
|
* @author Ev Haus
|
|
*/
|
|
|
|
'use strict';
|
|
|
|
const Components = require('../util/Components');
|
|
const propsUtil = require('../util/props');
|
|
const docsUrl = require('../util/docsUrl');
|
|
const propWrapperUtil = require('../util/propWrapper');
|
|
|
|
// ------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
// ------------------------------------------------------------------------------
|
|
|
|
// Predefine message for use in context.report conditional.
|
|
// messageId will still be usable in tests.
|
|
const PATTERN_MISMATCH_MSG = 'Prop name ({{propName}}) doesn\'t match rule ({{pattern}})';
|
|
|
|
module.exports = {
|
|
meta: {
|
|
docs: {
|
|
category: 'Stylistic Issues',
|
|
description: 'Enforces consistent naming for boolean props',
|
|
recommended: false,
|
|
url: docsUrl('boolean-prop-naming')
|
|
},
|
|
|
|
messages: {
|
|
patternMismatch: PATTERN_MISMATCH_MSG
|
|
},
|
|
|
|
schema: [{
|
|
additionalProperties: false,
|
|
properties: {
|
|
propTypeNames: {
|
|
items: {
|
|
type: 'string'
|
|
},
|
|
minItems: 1,
|
|
type: 'array',
|
|
uniqueItems: true
|
|
},
|
|
rule: {
|
|
default: '^(is|has)[A-Z]([A-Za-z0-9]?)+',
|
|
minLength: 1,
|
|
type: 'string'
|
|
},
|
|
message: {
|
|
minLength: 1,
|
|
type: 'string'
|
|
},
|
|
validateNested: {
|
|
default: false,
|
|
type: 'boolean'
|
|
}
|
|
},
|
|
type: 'object'
|
|
}]
|
|
},
|
|
|
|
create: Components.detect((context, components, utils) => {
|
|
const config = context.options[0] || {};
|
|
const rule = config.rule ? new RegExp(config.rule) : null;
|
|
const propTypeNames = config.propTypeNames || ['bool'];
|
|
|
|
// Remembers all Flowtype object definitions
|
|
const objectTypeAnnotations = new Map();
|
|
|
|
/**
|
|
* Returns the prop key to ensure we handle the following cases:
|
|
* propTypes: {
|
|
* full: React.PropTypes.bool,
|
|
* short: PropTypes.bool,
|
|
* direct: bool,
|
|
* required: PropTypes.bool.isRequired
|
|
* }
|
|
* @param {Object} node The node we're getting the name of
|
|
* @returns {string | null}
|
|
*/
|
|
function getPropKey(node) {
|
|
// Check for `ExperimentalSpreadProperty` (ESLint 3/4) and `SpreadElement` (ESLint 5)
|
|
// so we can skip validation of those fields.
|
|
// Otherwise it will look for `node.value.property` which doesn't exist and breaks ESLint.
|
|
if (node.type === 'ExperimentalSpreadProperty' || node.type === 'SpreadElement') {
|
|
return null;
|
|
}
|
|
if (node.value && node.value.property) {
|
|
const name = node.value.property.name;
|
|
if (name === 'isRequired') {
|
|
if (node.value.object && node.value.object.property) {
|
|
return node.value.object.property.name;
|
|
}
|
|
return null;
|
|
}
|
|
return name;
|
|
}
|
|
if (node.value && node.value.type === 'Identifier') {
|
|
return node.value.name;
|
|
}
|
|
return null;
|
|
}
|
|
|
|
/**
|
|
* Returns the name of the given node (prop)
|
|
* @param {Object} node The node we're getting the name of
|
|
* @returns {string}
|
|
*/
|
|
function getPropName(node) {
|
|
// Due to this bug https://github.com/babel/babel-eslint/issues/307
|
|
// we can't get the name of the Flow object key name. So we have
|
|
// to hack around it for now.
|
|
if (node.type === 'ObjectTypeProperty') {
|
|
return context.getSourceCode().getFirstToken(node).value;
|
|
}
|
|
|
|
return node.key.name;
|
|
}
|
|
|
|
/**
|
|
* Checks if prop is declared in flow way
|
|
* @param {Object} prop Property object, single prop type declaration
|
|
* @returns {Boolean}
|
|
*/
|
|
function flowCheck(prop) {
|
|
return (
|
|
prop.type === 'ObjectTypeProperty'
|
|
&& prop.value.type === 'BooleanTypeAnnotation'
|
|
&& rule.test(getPropName(prop)) === false
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Checks if prop is declared in regular way
|
|
* @param {Object} prop Property object, single prop type declaration
|
|
* @returns {Boolean}
|
|
*/
|
|
function regularCheck(prop) {
|
|
const propKey = getPropKey(prop);
|
|
return (
|
|
propKey
|
|
&& propTypeNames.indexOf(propKey) >= 0
|
|
&& rule.test(getPropName(prop)) === false
|
|
);
|
|
}
|
|
|
|
function tsCheck(prop) {
|
|
if (prop.type !== 'TSPropertySignature') return false;
|
|
const typeAnnotation = (prop.typeAnnotation || {}).typeAnnotation;
|
|
return (
|
|
typeAnnotation
|
|
&& typeAnnotation.type === 'TSBooleanKeyword'
|
|
&& rule.test(getPropName(prop)) === false
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Checks if prop is nested
|
|
* @param {Object} prop Property object, single prop type declaration
|
|
* @returns {Boolean}
|
|
*/
|
|
function nestedPropTypes(prop) {
|
|
return (
|
|
prop.type === 'Property'
|
|
&& prop.value.type === 'CallExpression'
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Runs recursive check on all proptypes
|
|
* @param {Array} proptypes A list of Property object (for each proptype defined)
|
|
* @param {Function} addInvalidProp callback to run for each error
|
|
*/
|
|
function runCheck(proptypes, addInvalidProp) {
|
|
proptypes = proptypes || [];
|
|
|
|
proptypes.forEach((prop) => {
|
|
if (config.validateNested && nestedPropTypes(prop)) {
|
|
runCheck(prop.value.arguments[0].properties, addInvalidProp);
|
|
return;
|
|
}
|
|
if (flowCheck(prop) || regularCheck(prop) || tsCheck(prop)) {
|
|
addInvalidProp(prop);
|
|
}
|
|
});
|
|
}
|
|
|
|
/**
|
|
* Checks and mark props with invalid naming
|
|
* @param {Object} node The component node we're testing
|
|
* @param {Array} proptypes A list of Property object (for each proptype defined)
|
|
*/
|
|
function validatePropNaming(node, proptypes) {
|
|
const component = components.get(node) || node;
|
|
const invalidProps = component.invalidProps || [];
|
|
|
|
runCheck(proptypes, (prop) => {
|
|
invalidProps.push(prop);
|
|
});
|
|
|
|
components.set(node, {
|
|
invalidProps
|
|
});
|
|
}
|
|
|
|
/**
|
|
* Reports invalid prop naming
|
|
* @param {Object} component The component to process
|
|
*/
|
|
function reportInvalidNaming(component) {
|
|
component.invalidProps.forEach((propNode) => {
|
|
const propName = getPropName(propNode);
|
|
context.report(Object.assign({
|
|
node: propNode,
|
|
data: {
|
|
component: propName,
|
|
propName,
|
|
pattern: config.rule
|
|
}
|
|
}, config.message ? {message: config.message} : {messageId: 'patternMismatch'}));
|
|
});
|
|
}
|
|
|
|
function checkPropWrapperArguments(node, args) {
|
|
if (!node || !Array.isArray(args)) {
|
|
return;
|
|
}
|
|
args.filter((arg) => arg.type === 'ObjectExpression').forEach((object) => validatePropNaming(node, object.properties));
|
|
}
|
|
|
|
// --------------------------------------------------------------------------
|
|
// Public
|
|
// --------------------------------------------------------------------------
|
|
|
|
return {
|
|
ClassProperty(node) {
|
|
if (!rule || !propsUtil.isPropTypesDeclaration(node)) {
|
|
return;
|
|
}
|
|
if (
|
|
node.value
|
|
&& node.value.type === 'CallExpression'
|
|
&& propWrapperUtil.isPropWrapperFunction(
|
|
context,
|
|
context.getSourceCode().getText(node.value.callee)
|
|
)
|
|
) {
|
|
checkPropWrapperArguments(node, node.value.arguments);
|
|
}
|
|
if (node.value && node.value.properties) {
|
|
validatePropNaming(node, node.value.properties);
|
|
}
|
|
if (node.typeAnnotation && node.typeAnnotation.typeAnnotation) {
|
|
validatePropNaming(node, node.typeAnnotation.typeAnnotation.properties);
|
|
}
|
|
},
|
|
|
|
MemberExpression(node) {
|
|
if (!rule || !propsUtil.isPropTypesDeclaration(node)) {
|
|
return;
|
|
}
|
|
const component = utils.getRelatedComponent(node);
|
|
if (!component || !node.parent.right) {
|
|
return;
|
|
}
|
|
const right = node.parent.right;
|
|
if (
|
|
right.type === 'CallExpression'
|
|
&& propWrapperUtil.isPropWrapperFunction(
|
|
context,
|
|
context.getSourceCode().getText(right.callee)
|
|
)
|
|
) {
|
|
checkPropWrapperArguments(component.node, right.arguments);
|
|
return;
|
|
}
|
|
validatePropNaming(component.node, node.parent.right.properties);
|
|
},
|
|
|
|
ObjectExpression(node) {
|
|
if (!rule) {
|
|
return;
|
|
}
|
|
|
|
// Search for the proptypes declaration
|
|
node.properties.forEach((property) => {
|
|
if (!propsUtil.isPropTypesDeclaration(property)) {
|
|
return;
|
|
}
|
|
validatePropNaming(node, property.value.properties);
|
|
});
|
|
},
|
|
|
|
TypeAlias(node) {
|
|
// Cache all ObjectType annotations, we will check them at the end
|
|
if (node.right.type === 'ObjectTypeAnnotation') {
|
|
objectTypeAnnotations.set(node.id.name, node.right);
|
|
}
|
|
},
|
|
|
|
TSTypeAliasDeclaration(node) {
|
|
if (node.typeAnnotation.type === 'TSTypeLiteral') {
|
|
objectTypeAnnotations.set(node.id.name, node.typeAnnotation);
|
|
}
|
|
},
|
|
|
|
// eslint-disable-next-line object-shorthand
|
|
'Program:exit'() {
|
|
if (!rule) {
|
|
return;
|
|
}
|
|
|
|
const list = components.list();
|
|
Object.keys(list).forEach((component) => {
|
|
// If this is a functional component that uses a global type, check it
|
|
if (
|
|
(
|
|
list[component].node.type === 'FunctionDeclaration'
|
|
|| list[component].node.type === 'ArrowFunctionExpression'
|
|
)
|
|
&& list[component].node.params
|
|
&& list[component].node.params.length
|
|
&& list[component].node.params[0].typeAnnotation
|
|
) {
|
|
const typeNode = list[component].node.params[0].typeAnnotation;
|
|
const annotation = typeNode.typeAnnotation;
|
|
let propType;
|
|
if (annotation.type === 'GenericTypeAnnotation') {
|
|
propType = objectTypeAnnotations.get(annotation.id.name);
|
|
} else if (annotation.type === 'ObjectTypeAnnotation') {
|
|
propType = annotation;
|
|
} else if (annotation.type === 'TSTypeReference') {
|
|
propType = objectTypeAnnotations.get(annotation.typeName.name);
|
|
}
|
|
|
|
if (propType) {
|
|
validatePropNaming(
|
|
list[component].node,
|
|
propType.properties || propType.members
|
|
);
|
|
}
|
|
}
|
|
|
|
if (list[component].invalidProps && list[component].invalidProps.length > 0) {
|
|
reportInvalidNaming(list[component]);
|
|
}
|
|
});
|
|
|
|
// Reset cache
|
|
objectTypeAnnotations.clear();
|
|
}
|
|
};
|
|
})
|
|
};
|