Update react to use .env

README.md

@@ -6,30 +6,31 @@ Stack: Go 1.16+, Node 15+, React 17+, MySQL 8.0+, Redis
 
 There are prebuilt binaries/packages available.
 
-
 Copy .env.example to .env and set variables. You can use https://www.grc.com/passwords.htm to generate a JWT_SECRET.
 
+## More documentation
+[Environment Variables](docs/config.md)
+
 ## Setup MySQL
     create user 'goscrobble'@'%' identified by 'supersecurepass';
     create database goscrobble;
     grant all privileges on goscrobble.* to 'goscrobble'@'%';
 
-## Local build/run
+## Local Development
     cp .env.example .env # Fill in the blanks
-    cd web && npm install && REACT_APP_API_URL=http://127.0.0.1:42069 npm start
-    # In another terminal
     go mod tidy
     CGO_ENABLED=0 go run cmd/go-scrobble/*.go
+    # In another terminal set web/.env.development
+    cd web && npm install && npm start --env development
+
 
 Access dev frontend @ http://127.0.0.1:3000 + API @ http://127.0.0.1:42069/api/v1
 
-## Run local tests
-    go test test/*
-
 ## Prod deployment
 We need to build NPM package, and then ship web/build with the binary.
+
     cp .env.example .env # Fill in the blanks
-    cd web npm install --production && REACT_APP_API_URL=https://goscrobble.com npm run build
+    cd web npm install --production && npm run build --env production
     go build -o goscrobble cmd/go-scrobble/*.go
     ./goscrobble
 

docs/config.md

@@ -1,4 +1,6 @@
 ## FRONTEND VARS
+These are stored in `web/.env.production` and `web/.env.development`
+
     REACT_APP_REGISTRATION_DISABLED=true // Disables registration
     REACT_APP_API_URL=https://goscrobble.com // Sets API URL
 

web/.env.development

@@ -0,0 +1,2 @@
+REACT_APP_API_URL=http://127.0.0.1:42069
+REACT_APP_REGISTRATION_DISABLED=false

web/.env.production

@@ -0,0 +1,2 @@
+REACT_APP_API_URL=https://goscrobble.com
+REACT_APP_REGISTRATION_DISABLED=true